Skip to content

feat: schedule Feynman upgrade on Scroll mainnet #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2025
Merged

feat: schedule Feynman upgrade on Scroll mainnet #1230

merged 1 commit into from
Aug 6, 2025

Conversation

Thegaram
Copy link

@Thegaram Thegaram commented Aug 4, 2025 •
edited by coderabbitai bot
Loading

1. Purpose or design rationale of this PR

Timestamp 1755576000.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

Summary by CodeRabbit

  • Chores
    • Updated the activation time for the Feynman fork on Scroll Mainnet.
    • Incremented the patch version number.

@Thegaram Thegaram requested review from jonastheis and roylou August 4, 2025 09:17
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Aug 4, 2025 •
edited
Loading

Walkthrough

This change updates the activation time for the Feynman fork in the Scroll Mainnet chain configuration and increments the patch version constant in the params package. No other logic, control flow, or public API is affected.

Changes

Cohort / File(s) Change Summary
Scroll Mainnet ChainConfig Update
params/config.go		 Sets FeynmanTime in ScrollMainnetChainConfig from nil to a specific uint64 pointer value.
Patch Version Bump
params/version.go		 Increments the VersionPatch constant from 76 to 77.

Sequence Diagram(s)

Not applicable: No new feature or control flow introduced.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

bump-version

Suggested reviewers

  • jonastheis
  • georgehao
  • yiweichi

Poem

A patch hops in, so small and neat,
Feynman’s time now set, no more incomplete.
Mainnet’s fork awaits its date,
Version ticks up—seventy-seven, great!
With gentle paws, we nudge along,
Scroll’s chain grows ever strong.
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 35bc5a9 and 04e3694.

📒 Files selected for processing (2)
  • params/config.go (1 hunks)
  • params/version.go (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: check
  • GitHub Check: test
  • GitHub Check: Analyze (go)
🔇 Additional comments (2)
params/version.go (1)

27-27: Version patch bump looks good.

No functional concerns—constant updated as expected.
Remember to cut and push the v5.8.77 tag and update any downstream release notes once this lands.

params/config.go (1)

388-388: Timestamp Confirmed Correct

The Unix timestamp 1755576000 indeed corresponds to Tue Aug 19 04:00:00 UTC 2025. No changes to the code are needed.

• Please ensure all deployment documentation and announcements consistently reference 2025-08-19 04:00:00 UTC for the Feynman activation.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat-mainnet-schedule-feynman

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Thegaram
Thegaram commented Aug 4, 2025
View reviewed changes
@Thegaram Thegaram mentioned this pull request Aug 5, 2025
Open
13 tasks
@Thegaram Thegaram merged commit 25369b2 into develop Aug 6, 2025
14 checks passed
@Thegaram Thegaram deleted the feat-mainnet-schedule-feynman branch August 6, 2025 06:01
@coderabbitai coderabbitai bot mentioned this pull request Aug 7, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonastheis jonastheis jonastheis approved these changes

@roylou roylou Awaiting requested review from roylou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thegaram @jonastheis